Skip to content

[Forwardport] Fixed a grammatical error on the vault tooltip #17229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Forwardport] Fixed a grammatical error on the vault tooltip #17229

wants to merge 1 commit into from

Conversation

tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jul 28, 2018 •
edited by ihor-sviziev
Loading

Original Pull Request

#17151

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

sreichel
sreichel reviewed Jul 28, 2018
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same translation also exists in app/code/Magento/Braintree/view/frontend/web/template/payment/form.html

@ihor-sviziev
Copy link
Contributor

Hi @tiagosampaio,
We already have forwardport PR #17197
I'm closing this PR as duplicate.

@ihor-sviziev ihor-sviziev self-assigned this Jul 28, 2018
@tiagosampaio tiagosampaio deleted the 2.3-develop-PR-port-17151 branch August 7, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel left review comments

Assignees

@ihor-sviziev ihor-sviziev

Labels
Area: Frontend Component: Braintree duplicate Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagosampaio @magento-engcom-team @ihor-sviziev @sreichel